fix #1219 convert v2 time offsets to sr3 correctly

[petersilva]

not the most general way to fix it, but via find and grep... I only found -1D, and -2D... so that's really all the cases we need to take care of... anyways... does enough of the job.

[github-actions]

Test Results

248 tests   247 ✅  1m 27s ⏱️
  1 suites    1 💤
  1 files      0 ❌

Results for commit 6673508.

[petersilva]

the flow test failures we see have nothing to do with the branch.

[petersilva]

@reidsunderland surmised the patch does not work if the strings do not end with the date pattern... did some tests... he is right, this does not fix that case.

directory /tmp/hpfx_amis/${HOHO}/${YYYYMMDD-1D}/lala

different approach needed.

[petersilva]

broken existing configs:
'''

./ddsr_science20/poll/hpfx-dfo.conf:directory /data/dd/public_data/dfo/pops_model/${YYYYMMDD-1D}/canso100
./ddsr-stage/poll/class_noaa.conf:directory /${YYYYMMDD-1D}/VIIRS-SDR/VIIRS-Moderate-Resolution-Band-01-SDR/J01/

'''
on the other hand... all occurrences of date offsets are either ${YYYYMMDD-1D} or ${YYYYMMDD-2D} ... so could just replace those
two strings outright and it would work for all extant cases.

[petersilva]

The original syntax was meant to work in other contexts... but it looks like only the full date is actually used anywhere.

[petersilva]

went a different way... other way already merged.