Issue1155 AMQP ack refactor #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
failures to the caller (message.gather's ack method) - message.gather's ack now deletes the ack_id from messages instead of the moth classes - AMQP: refuses to attempt to ack a message if it was received on a different channel, connection or broker (preventing unecessary connection tear down and re-establish) - AMQP: when ack is attempted and fails because the connection to the broker is broken, don't loop and retry. After re-connecting, acking that message would always fail, prevents a potential infinite loop.
…ith the ack_id after a failed ack is protocol specific
Test Results1 tests 0 ✅ 14s ⏱️ For more details on these errors, see this check. Results for commit 2891472. ♻️ This comment has been updated with latest results. |
petersilva
approved these changes
Aug 19, 2024
|
The tests are messed up atm... but I think this change is ok anyways... in an ideal world we would fix the tests... but no clue what is with 20.04. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AMQP: refuse to attempt to ack a message if it was received on a different channel, connection or broker (preventing unnecessary
connection tear down and re-establish)
AMQP: when ack is attempted and fails because the connection to the broker is broken, cleanup (close) the broken connection and don't bother attempting to retry the ack
Also changed the ack method to return a boolean, which wasn't needed but could possibly be useful someday if we want to change how we handle a failed ack.