Issue339 part2 queue names #1149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needed a string index for url. json encodeer was barfing on credentials, created a string routine for it to use instead. I think I might have a similar problem in flakey with retry queues and messages. also acks were not working (self.consumers instead of self.consumer) and got rid of some debug output.
petersilva
requested review from
reidsunderland,
MagikEh,
andreleblanc11 and
mshak2
Test Results2 tests 0 ✅ 14s ⏱️ For more details on these errors, see this check. Results for commit 8ddeeae. |
|
closing to to feature branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second phase of work in issue339, being able to gather messages from multiple sources. It adds all of the queue settings into the binding structure.
Bindings used to have three elements: exchange, topicPrefix, subtopic, but now they need:
broker, queueName, and all the settings related to declaring and binding a queue... so: expiry, durable, queueBind, queueDeclare, auto_delete, prefetch....
All of those settings become binding/consumer specific.
so that is too much to keep track of in a tuple, so changed the binding into a dictionary.
This is mean to be merged after part1 is merged... the patches in part1 break flow tests, so they need to be collapsed into a single patch. In contrast, these patches all preserve full flow_test compatibility, so a merge is fine (desirable actually to have smaller patches to work on bisection.)
The feature still isn't finished though... need to replace .qname files with .binding files, and figure out how to read them in.... there will beed to be a part 3.