Fix for #1137. Have wait_until_next return a boolean based on if housekeeping is needed or not. Fix other flowcbs accordingly

[andreleblanc11]

This fixes #1137. I tested the code with scheduled_interval set and scheduled_minute/hour and they both looked to be working correctly. The housekeeping doesn't run the gather retrieval anymore.

The problem is the gather needs to know if housekeeping is running or not to exit. I added return values from wait_until_next to accomplish this.

There's already a scheduled flow plugin http_with_metadata that has a fix inside of the plugin code to avoid this, but it isn't universal.

sarracenia/sarracenia/flowcb/scheduled/http_with_metadata.py

Lines 37 to 42 in 6ef61f6

	# for next expected post
	self.wait_until_next()
	if self.stop_requested or self.housekeeping_needed:
	return (False, [])

[github-actions]

Test Results

246 tests   245 ✅  1m 8s ⏱️
  1 suites    1 💤
  1 files      0 ❌

Results for commit 168d93e.

♻️ This comment has been updated with latest results.

[petersilva]

after looking it over together we think the problem is in the scheduled plugins (in sr3-plugins repo) not implementing a guard for housekeeping_needed... so this PR is not needed.