bad log message when sending fails.

[petersilva]

          ( Including this in this issue as it has to do with logging being misintepreted. )

When a file fails to be put through a ftp transfer with a sender, the logging gives a very confusing response. It states that it fails but then goes on to confirm success of the transfer. I confirmed that the transfer did in fact fail and the success log is wrong.

2024-12-06 16:04:45,324 [ERROR] sarracenia.transfer.ftp put failed to put cmcrfe.2024120600_036 to cmcrfe.2024120600_036: 550 Permission denied.
2024-12-06 16:04:45,325 [DEBUG] sarracenia.transfer.ftp chmod sr_ftp chmod 420 cmcrfe.2024120600_036
2024-12-06 16:04:45,389 [INFO] sarracenia.flow send Sent: /apps/sarra/public_data//20241206/MSC-SCI-CMC-OPS/noaa/cmcrfe.2024120600_036  into
/in/cmcrfe.2024120600_036 0-41063
2024-12-06 16:04:45,389 [DEBUG] sarracenia.flow.sender do processing 1 messages worked!
2024-12-06 16:04:45,389 [DEBUG] sarracenia.flowcb.retry after_work loading from post_retry_001: qty=24 ... got: 0
2024-12-06 16:04:45,389 [INFO] sarracenia.flowcb.log after_work sent ok: /in/cmcrfe.2024120600_036

I think the problem is that the try/except statement in here

sarracenia/sarracenia/flow/__init__.py

Lines 2656 to 2672 in da9dd37

	elif inflight[0] == '.':
	new_inflight_path = new_file + inflight
	if not self.o.dry_run:
	try:
	if accelerated:
	len_written = self.proto[self.scheme].putAccelerated(
	msg, local_file, new_inflight_path)
	else:
	len_written = self.proto[self.scheme].put(msg, local_file, new_inflight_path)
	except Exception as ex:
	logger.error( f"could not send {local_dir}{os.sep}{local_file} inflight={inflight} {sendTo} {msg['new_dir']}/{new_file}: {ex}" )
	return 0
	try:
	self.proto[self.scheme].rename(new_inflight_path, new_file)
	except Exception as ex:
	logger.error( f"could not rename inflight={inflight} {sendTo} {msg['new_dir']}/{new_file}: {ex}" )
	return 0

we should be checking if the len_written is greater then 0, and indicate a failed transfer if it is.

Originally posted by @andreleblanc11 in #1325 (comment)

[petersilva]

slight complication... some files are zero length... have to compare intended length as well.
if could be ok to send a zero length file.