-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customizable logging for message parts? #1195
Comments
copying stuff over from #1156...
to ... post? or accept, or both? (the routines in sarracenia/flowcb/log are _messageAcceptStr and _messagePostStr |
I don't know if the changes to default would be enough to obviate the need for programmable fields. the best part is no part ... Elon Musk |
so... looking at log.py, I see that _messagePostStr is not even called by default, it calls just messageIDStr which is literally just the URL... maybe we need an overarching logging verbosity setting? something like:
|
I thought this would be a five minute job... but the flow tests use the log outputs, so it's means modifying them all... |
to avoid messing with the tests... just make sure the new fields are near the end.
This is from static, so no sundew_extension present... but I really like the short id string. |
maybe fix #1195 more log fields by default
The current logging that shows accepted and posted messages comes from flowcb/log https://github.com/MetPX/sarracenia/blob/development/sarracenia/flowcb/log.py.
In some cases, it would be useful to show additional information like the sundew_extension, size, checksum, pubTime, but these aren't necessarily useful in all cases.
We have a logEvents option that makes it possible to fine tune which log messages show up. Maybe it's too much fine tuning, but we could add another option that that lets us define which part of the message we want to see in the log (add sundew_extension, etc. when useful).
We do have messageDebugDump, but it shows too much information for most cases, and the dictionary format is harder to read. I also just noticed that it's not documented in SR3 Options.
The text was updated successfully, but these errors were encountered: