Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firmware/network/radio: Radio module fixed gets functions #362

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

CW-75
Copy link
Collaborator

@CW-75 CW-75 commented Oct 13, 2022

Contribution description

Currently the getsfunction from radio module are not returning the tx_power or channel. only are printing in debug mode, within of the function. so, if you want to read the value of tx_poweror channel already it's accessible.
There is a little delay to set the tx_power of radio interface, you can see that in driver_radio test. if you remove that delay, you could see the Tx_power in 0.

Testing procedure

Run using the tests/driver_radio

make -C tests/driver_radio flash term

Issues/PRs references

Copy link
Contributor

@luisan00 luisan00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, only a few proposals for review and it's ready to go ahead

@CW-75 CW-75 force-pushed the bug/radio_settings branch from a794edd to e8f100e Compare October 14, 2022 15:32
@CW-75 CW-75 requested a review from luisan00 October 14, 2022 15:32
@CW-75 CW-75 force-pushed the bug/radio_settings branch from e8f100e to 5b6dcdb Compare October 14, 2022 15:34
@CW-75 CW-75 force-pushed the bug/radio_settings branch from 5b6dcdb to 164252e Compare October 14, 2022 15:36
Copy link
Contributor

@luisan00 luisan00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now looks ready!

@CW-75 CW-75 merged commit df98d24 into Mesh4all:main Oct 14, 2022
@CW-75 CW-75 deleted the bug/radio_settings branch October 14, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants