Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firmware/sys/storage: Added supports to save specified data types #360

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

CW-75
Copy link
Collaborator

@CW-75 CW-75 commented Oct 10, 2022

Contribution description

Was Added support to provide an specified data types registers, can be processed uint8_t, uint16_t, and uint32_t for all unsigned data types, for signed datatypes ìnt8_t, int16_t and ìnt32_t, also could be processed strings data types, only specifying its length.

Testing procedure

run the storage test. tests/system_storage/

make -C tests/system_storage flash term

Issues/PRs references

Copy link
Contributor

@luisan00 luisan00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really a good job, just some suggestion for discussion

@luisan00
Copy link
Contributor

Tested on:

  • native
  • samd21 platforms: m4a-24g and m4a-mb
  • cc2538 platforms: vs203 and meshme

.. and works well on all these boards 👏

@luisan00 luisan00 modified the milestones: 0.22.12-RC2, 0.22.12 Oct 11, 2022
@luisan00 luisan00 self-requested a review October 11, 2022 13:48
Copy link
Contributor

@luisan00 luisan00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job bro! 👍

@CW-75 CW-75 merged commit c8e0dd3 into Mesh4all:main Oct 11, 2022
@CW-75 CW-75 deleted the feature/storage branch October 11, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants