Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firmware/sys/shell_extended: Adds support for net_tools commands #354

Merged
merged 5 commits into from
Oct 7, 2022

Conversation

luisan00
Copy link
Contributor

Contribution description

Adds support for net_tools module into shell-extended module

Testing procedure

Go to examples/shell_extended and add the next line:

USEMODULE += net_tools

A good place for it could be just under USEMODULE += uniqueid, after it save changes, build and flash as usual:

make flash term

Once the shell is displayed, type help and push return or type one of the available commands for net-tools or uniqueid

Issues/PRs references

None

@luisan00 luisan00 changed the title firmware/sys/shell_extended: Adds support for net_tools commands [WIP] firmware/sys/shell_extended: Adds support for net_tools commands Sep 23, 2022
@luisan00 luisan00 added this to the 0.22.12-RC2 milestone Sep 23, 2022
@luisan00 luisan00 changed the title [WIP] firmware/sys/shell_extended: Adds support for net_tools commands firmware/sys/shell_extended: Adds support for net_tools commands Sep 26, 2022
@luisan00 luisan00 requested a review from CW-75 September 26, 2022 11:26
@CW-75
Copy link
Collaborator

CW-75 commented Sep 26, 2022

I added some new changes in net_tools shell_extended commands, this will provides the functionalities to run all features as setting ipv6 by uniqueid. You can provides an ipv6 address using the generic input of ipv6. e.g: 2001:db8::/64.

Testing procedure.

  • use the shell_extended_example:
make -C examples/shell_extended flash term

commands instructions:

if 4 add ipuid 2001:db8::/64 static

if --> command net_tool
4 --> interface id (Depends of your interface device).
add --> option to add an ipv6 addr (For this moments).
ipuid --> Additional and Exclusive option to generate and set a ipv6 address via `uniqueid` module.
2001:db8::/64 --> ipv6 address and network prefix. *note*: Always be predefined to get a random or static pv6 from a header. Remember add its prefix length.
static -> its the uniqueid ipv6 generation mode.

Copy link
Collaborator

@CW-75 CW-75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this looks good, but i prefer as own @luisan00, you give me your opinion about these features and commands.

@luisan00
Copy link
Contributor Author

yep, looks good, let me to check the latest changes before to merge please 🙏

@luisan00
Copy link
Contributor Author

what do you think about other command (without args) like:

  • if : show pretty printed interfaces and stats
    or (with argument):
  • if show: pretty print all interfaces and stats.
  • if show [iface]: for example if show 4, should print interface 4 and stats

@luisan00 luisan00 merged commit b67d5da into Mesh4all:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants