Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firmware/radio: Compillation Fixed to unregister netdev devices #325

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

CW-75
Copy link
Collaborator

@CW-75 CW-75 commented Jul 25, 2022

Contribution description

This contribution adds support to unregistered network devices, example if the netdev interface doesn't exist, All the operations of the module, should be stopped.

Testing procedure

The test with cc1312-launchpad board.

step to provide the uniflash programmer (also could be used openocd as programmer)

export PROGRAMMER=uniflash

then, run the test radio.

make -C tests/radio flash term BOARD=cc1312-launchpad

Expected results

Well, if the device doesn't have a radio interface, the all ran tests should been failed.

2022-07-25 17:36:57,965 # radio_tests.test_get_netopt_channel (/home/eduardo-az/github-forks/m4a-firmware/tests/radio/main.c 40) exp 0 was -1
2022-07-25 17:36:57,979 # .Error: Radio interface doesn't exist, File:/home/eduardo-az/github-forks/m4a-firmware/firmware/network/radio/radio.c line:69 function: get_ieee802154_iface
2022-07-25 17:36:57,992 # Error: Radio interface doesn't exist, File:/home/eduardo-az/github-forks/m4a-firmware/firmware/network/radio/radio.c line:69 function: get_ieee802154_iface
2022-07-25 17:36:57,995 # Error: Failed to add TX_power.
2022-07-25 17:36:57,995 # 
2022-07-25 17:36:58,005 # radio_tests.test_initial_radio_setup (/home/eduardo-az/github-forks/m4a-firmware/tests/radio/main.c 45) exp 0 was -1
2022-07-25 17:36:58,005 # 
2022-07-25 17:36:58,007 # run 4 failures 4

This resolved a support to compile in the no-radio devices

Issues/PRs references

Fixes #324

@CW-75 CW-75 added this to the 0.22.12-RC1 milestone Jul 25, 2022
@CW-75 CW-75 force-pushed the feature/radio_unnetdev_support branch from d247ab3 to 69415b9 Compare July 25, 2022 21:45
@CW-75 CW-75 requested a review from luisan00 July 25, 2022 21:49
Copy link
Contributor

@luisan00 luisan00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go ahead 👍

@CW-75 CW-75 merged commit 0c29af9 into Mesh4all:main Jul 26, 2022
@CW-75 CW-75 deleted the feature/radio_unnetdev_support branch July 26, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error compiling for unhandled MCUs
2 participants