Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: renamed tests with correctly test name #322

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

CW-75
Copy link
Collaborator

@CW-75 CW-75 commented Jul 19, 2022

Contribution description

This PR is to fix the wrong names writen in some tests. was renamed to correct name for each test.

Testing procedure

test only building each test:

make -C tests/serialization
make -C tests/radio

Note: Please before to run the test ds18, connect your peripheral in the pin CONFIG_PIN_TEMP_SENSOR. (by default is the pin 5 of m4a-24g)

make -C tests/ds18

Expected results ( test/serialization )

2022-07-19 21:42:01,471 # START
2022-07-19 21:42:01,476 # main(): This is RIOT! (Version: 2022.07-devel-934-g6b7d8-HEAD)
2022-07-19 21:42:01,477 # ..
2022-07-19 21:42:01,478 # OK (2 tests)
2022-07-19 21:42:08,182 # Exiting Pyterm

Expected results ( test/radio )

2022-07-19 21:45:17,493 # START
2022-07-19 21:45:17,498 # main(): This is RIOT! (Version: 2022.07-devel-934-g6b7d8-HEAD)
2022-07-19 21:45:17,500 # ..TX-Power: 0dBm 
2022-07-19 21:45:17,502 # .Channel: 26 
2022-07-19 21:45:17,503 # . TX-Power: 0dBm 
2022-07-19 21:45:17,505 #  channel: 11 
2022-07-19 21:45:17,505 # 
2022-07-19 21:45:17,506 # OK (4 tests)

Expected resulst ( test/ds18 )

2022-07-19 21:51:46,546 # START
2022-07-19 21:51:46,552 # main(): This is RIOT! (Version: 2022.07-devel-934-g6b7d8-HEAD)
2022-07-19 21:51:46,553 # .DS18 initialized
2022-07-19 21:51:47,318 # .
2022-07-19 21:51:47,319 # OK (2 tests)
2022-07-19 21:51:52,451 # Exiting Pyterm

Issues/PRs references

@CW-75 CW-75 added this to the 0.22.12-RC1 milestone Jul 19, 2022
@CW-75 CW-75 requested a review from luisan00 July 19, 2022 02:59
@luisan00
Copy link
Contributor

What about tests output?

@CW-75
Copy link
Collaborator Author

CW-75 commented Jul 20, 2022

Ok already, the tests output was added to Pull Request description, thanks 👍

Copy link
Contributor

@luisan00 luisan00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good man 👍, and so, if all affected test, runs as expected this should be merged

@CW-75 CW-75 merged commit b815291 into Mesh4all:main Jul 20, 2022
@CW-75 CW-75 deleted the rename_test branch July 20, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants