Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firmware/storage: Fixed bug in Boards meshme and vs203 #317

Merged
merged 1 commit into from
Jul 18, 2022
Merged

firmware/storage: Fixed bug in Boards meshme and vs203 #317

merged 1 commit into from
Jul 18, 2022

Conversation

CW-75
Copy link
Collaborator

@CW-75 CW-75 commented Jul 15, 2022 •
edited
Loading

Contribution description

Contribution to provide support of storage module to new boards: was fixed reference to generic literals. FLASHPAGE_SIZE as MAXIMUN_SIZE_STORAGE and MAX_NUMOF_FLASHPAGEs as FLASHPAGE_NUMOF

Testing procedure

Testing with each board in test/storage

make -C tests/storage flash term

Issues/PRs references

@CW-75 CW-75 added this to the 0.22.12-RC1 milestone Jul 15, 2022
luisan00
luisan00 approved these changes Jul 16, 2022
View reviewed changes
Copy link
Contributor

@luisan00 luisan00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@CW-75 CW-75 merged commit ae76885 into Mesh4all:main Jul 18, 2022
@CW-75 CW-75 deleted the feature/storage_fixes branch July 18, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RocioRojas RocioRojas RocioRojas approved these changes

@luisan00 luisan00 luisan00 approved these changes

Assignees
No one assigned
Labels
Area: firmware Area: sys
Projects
None yet
Milestone
0.22.12-RC1
Development

Successfully merging this pull request may close these issues.
3 participants
@CW-75 @luisan00 @RocioRojas