Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/meshme: Add ADC support and tests #316

Merged
merged 2 commits into from
Jul 15, 2022
Merged

boards/meshme: Add ADC support and tests #316

merged 2 commits into from
Jul 15, 2022

Conversation

luisan00
Copy link
Contributor

Contribution description

This PR contains two related commits:

  • Add support for ADC peripheral on two lines of the meshme platform
  • tests/periph_adc

Testing procedure

Run the periph_adc test with:

make BOARD=meshme flash test

Issues/PRs references

None

@luisan00 luisan00 requested review from CW-75 and RocioRojas July 15, 2022 10:25
CW-75
CW-75 requested changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@CW-75 CW-75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, only need to fix a little EOF, to merge this

tests/periph_adc/app.config.test Outdated Show resolved Hide resolved
tests/periph_adc/app.config.test Outdated Show resolved Hide resolved
CW-75
CW-75 requested changes Jul 15, 2022
View reviewed changes
tests/periph_adc/doc.txt Outdated Show resolved Hide resolved
RocioRojas
RocioRojas reviewed Jul 15, 2022
View reviewed changes
Copy link
Contributor

@RocioRojas RocioRojas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me!!!, do a squash

@luisan00
Copy link
Contributor Author

@eduazocar the proposed changes were made

@luisan00 luisan00 added this to the 0.22.12-RC1 milestone Jul 15, 2022
@luisan00 luisan00 merged commit 104ba5a into Mesh4all:main Jul 15, 2022
@luisan00 luisan00 deleted the boards/meshme branch July 15, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RocioRojas RocioRojas RocioRojas left review comments

@CW-75 CW-75 CW-75 approved these changes

Assignees
No one assigned
Labels
Area: boards Area: doc Area: Kconfig Area: tests Platform: meshme
Projects
None yet
Milestone
0.22.12-RC1
Development

Successfully merging this pull request may close these issues.
3 participants
@luisan00 @RocioRojas @CW-75