Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network: Made kconfig to ds18 and moisture sensor #303

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Network: Made kconfig to ds18 and moisture sensor #303

merged 1 commit into from
Jul 12, 2022

Conversation

RocioRojas
Copy link
Contributor

Contribution description

Made kconfig to ds18 and moisture sensor module with the kconfig sets the configuration to pin for ds18 module and values default of moisture sensor.

Testing procedure

Run in terminal make menuconfig, look for the option ds18 or moisture sensor.

Issues/PRs references

@RocioRojas RocioRojas added this to the 0.22.12-RC1 milestone Jul 8, 2022
@RocioRojas RocioRojas changed the title Network: Made kconfig ds18 and moisture sensor Network: Made kconfig to ds18 and moisture sensor Jul 8, 2022
CW-75
CW-75 requested changes Jul 8, 2022
View reviewed changes
Copy link
Collaborator

@CW-75 CW-75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a good integration to kconfig params, but it needs some changes.

firmware/peripherals/Kconfig Show resolved Hide resolved
firmware/peripherals/moisture_sensor/Kconfig Outdated Show resolved Hide resolved
@RocioRojas RocioRojas force-pushed the mooisture_kconfig branch 2 times, most recently from 2a5342d to ca9ac48 Compare July 11, 2022 02:46
CW-75
CW-75 reviewed Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@CW-75 CW-75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see god, but i have a suggest to this PR

firmware/peripherals/moisture_sensor/Kconfig Outdated Show resolved Hide resolved
@RocioRojas RocioRojas force-pushed the mooisture_kconfig branch 2 times, most recently from 2a5cfe3 to f5599b5 Compare July 12, 2022 04:21
CW-75
CW-75 requested changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@CW-75 CW-75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good but, this it needs a little fixes, go ahead 👍

firmware/peripherals/moisture_sensor/Kconfig Show resolved Hide resolved
firmware/peripherals/moisture_sensor/Kconfig Outdated Show resolved Hide resolved
CW-75
CW-75 approved these changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@CW-75 CW-75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, go ahead 👍

@RocioRojas RocioRojas merged commit b61f40b into Mesh4all:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CW-75 CW-75 CW-75 approved these changes

Assignees
No one assigned
Labels
Area: examples Area: firmware Area: Kconfig Area: tests
Projects
None yet
Milestone
0.22.12-RC1
Development

Successfully merging this pull request may close these issues.
2 participants
@RocioRojas @CW-75