Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network: Made kconfig to chamos #300

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Network: Made kconfig to chamos #300

merged 1 commit into from
Jul 12, 2022

Conversation

RocioRojas
Copy link
Contributor

Contribution description

Made kconfig to chamos module with the kconfig sets the configuration to IPV6 address, the size of message and the buffer

Testing procedure

Run in terminal make menuconfig, look for the option chamos and choose of the IPV6 address, the size of message and the buffer

Issues/PRs references

@RocioRojas RocioRojas added this to the 0.22.12-RC1 milestone Jul 7, 2022
@RocioRojas RocioRojas added Status: WIP This PR is a work in progress and removed Status: WIP This PR is a work in progress labels Jul 7, 2022
@RocioRojas RocioRojas changed the title Network: made kconfig chamos Network: Made kconfig to chamos Jul 8, 2022
@RocioRojas RocioRojas force-pushed the chamos_kconfig branch 3 times, most recently from 34b7d20 to 077fa07 Compare July 10, 2022 23:33
CW-75
CW-75 reviewed Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@CW-75 CW-75 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the file firmware/network/radio.c

removes this line to the test works...

#include "uniqueid.h"

The other thing is when this is added the test was freezing in my screen, so could you need take a little check in the code

CW-75
CW-75 approved these changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@CW-75 CW-75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All it's working correctly, go ahead 👍

@RocioRojas RocioRojas merged commit 1a650cc into Mesh4all:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CW-75 CW-75 CW-75 approved these changes

Assignees
No one assigned
Labels
Area: firmware Area: Kconfig Area: network
Projects
None yet
Milestone
0.22.12-RC1
Development

Successfully merging this pull request may close these issues.
2 participants
@RocioRojas @CW-75