Network: Made Kconfig to border router module #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RocioRojas
added
Status: WIP
CW-75
requested changes
Jul 8, 2022
RocioRojas
force-pushed
the
kconfig
branch
3 times, most recently
from
bfa4907 to
6d8b36b
Compare
RocioRojas
force-pushed
the
kconfig
branch
3 times, most recently
from
48d763c to
8e037d4
Compare
RocioRojas
force-pushed
the
kconfig
branch
2 times, most recently
from
422712f to
ddcee66
Compare
CW-75
requested changes
Jul 11, 2022
There was a problem hiding this comment.
The variable values to int in the kconfig interface could throw an error if an user set both interfaces in the same int value
/home/eduardo-az/github-forks/m4a-firmware/firmware/network/border_router/border_router.c: In function 'border_router_setup':
/home/eduardo-az/github-forks/m4a-firmware/firmware/network/border_router/border_router.c:36:5: error: duplicate case value
36 | case CONFIG_WIRELESS_INTERFACE:
| ^~~~
/home/eduardo-az/github-forks/m4a-firmware/firmware/network/border_router/border_router.c:33:5: note: previously used here
33 | case CONFIG_WIRED_INTERFACE:
| ^~~~
```
CW-75
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Made kconfig to border router module with the kconfig sets the configuration to wired or wireless interface
Testing procedure
Run in terminal
make menuconfig, look for the option border router and choose between wired o wireless interface.Issues/PRs references