Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network/udp_client: Update udp client to pass the tests #288

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

CW-75
Copy link
Collaborator

@CW-75 CW-75 commented Jul 4, 2022

Contribution description

To fix some errors presented in the test of udp_client and udp_server. It was fixed the specified parameters in udp_client.h, changing the estimation of port from int to uint16_t, and this parameter should be constant, because the port never be affected or changed by the function. also the max number of internet ports are 65535, this is the maximun reach value in
uint16_t

Testing procedure

Issues/PRs references

@CW-75 CW-75 added the Type: bug Something isn't working label Jul 4, 2022
@CW-75 CW-75 added this to the 0.22.12-RC1 milestone Jul 4, 2022
@CW-75 CW-75 requested review from luisan00 and RocioRojas July 4, 2022 15:00
@CW-75 CW-75 changed the title network/udp_client: Update udp client to past the test network/udp_client: Update udp client to pass the test Jul 4, 2022
@CW-75 CW-75 changed the title network/udp_client: Update udp client to pass the test network/udp_client: Update udp client to pass the tests Jul 4, 2022
@CW-75 CW-75 merged commit 3a9eab8 into Mesh4all:main Jul 5, 2022
@CW-75 CW-75 deleted the feature/Udp_update branch July 5, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants