Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/m4a-24g: Adc VREF periph control by KCONFIG #286

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

CW-75
Copy link
Collaborator

@CW-75 CW-75 commented Jul 1, 2022

Contribution description

This new integration allows configure the VREF via Kconfig. I add the kconfig manipulation to only select an option of ADC_REF, so the only way to change by the moment it's using kconfig, when kconfig it's not apply to the application, example or firmware, the system will get the DEFAULT_VALUE of aref --> ADC_REF_DEFAULT = ADC_REFCTRL_REFSEL_INT1V

Testing procedure

Issues/PRs references

@CW-75 CW-75 added this to the 0.22.12-RC1 milestone Jul 1, 2022
@CW-75 CW-75 force-pushed the feature/adc_vref branch from 00d24e6 to 0b95240 Compare July 1, 2022 21:29
@CW-75 CW-75 requested review from luisan00 and RocioRojas July 1, 2022 21:29
@CW-75 CW-75 changed the title boards: Adc VREF periph control by KCONFIG boards/m4a-24g: Adc VREF periph control by KCONFIG Jul 3, 2022
Copy link
Contributor

@luisan00 luisan00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, only some nitpicks

boards/m4a-24g/include/periph_conf.h Outdated Show resolved Hide resolved
Copy link
Contributor

@RocioRojas RocioRojas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me, do squash!!!

@CW-75 CW-75 force-pushed the feature/adc_vref branch from 4f1dee6 to 6d4ac69 Compare July 4, 2022 12:48
@CW-75 CW-75 requested review from RocioRojas and luisan00 July 4, 2022 12:51
@CW-75 CW-75 merged commit 559c53e into Mesh4all:main Jul 4, 2022
@CW-75 CW-75 deleted the feature/adc_vref branch July 4, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants