Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wifi-subsys: added cJSON and changed cbor to json in the https-request #264

Merged
merged 1 commit into from
Jun 6, 2022
Merged

wifi-subsys: added cJSON and changed cbor to json in the https-request #264

merged 1 commit into from
Jun 6, 2022

Conversation

xkevin190
Copy link
Contributor

Contribution description

the cjson module was added to encode as json the messages that arrive from uart and send them to the server

@github-actions github-actions bot added Area: doc Area: wifi-subsys It is related to some subsystem labels Jun 6, 2022
@xkevin190 xkevin190 added this to the 0.22.06 milestone Jun 6, 2022
CW-75
CW-75 reviewed Jun 6, 2022
View reviewed changes
Copy link
Collaborator

@CW-75 CW-75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a suggest about this code, I didn't see that it's stores inside of subsys_uart module. So I think that could see better in main, because https protocol will be an dependency of this module

wifi-subsys/components/uart/src/subsys_uart.c Show resolved Hide resolved
CW-75
CW-75 approved these changes Jun 6, 2022
View reviewed changes
Copy link
Collaborator

@CW-75 CW-75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 go ahead.

@xkevin190 xkevin190 merged commit 8a2e76f into Mesh4all:main Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CW-75 CW-75 CW-75 approved these changes

@luisan00 luisan00 Awaiting requested review from luisan00

@RocioRojas RocioRojas Awaiting requested review from RocioRojas

Assignees
No one assigned
Labels
Area: doc Area: wifi-subsys It is related to some subsystem
Projects
None yet
Milestone
0.22.06
Development

Successfully merging this pull request may close these issues.
2 participants
@xkevin190 @CW-75