Wifi-subsys: Delete build warnings from icmp and recover https erased element #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CW-75
changed the title
xkevin190
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Implementation of some casting to fix some warning when it's build the protocols software, it's about all sectors of icmp, where was passing by nvs a value
uint8_ttouint32_tpointer-variable, another warning was aboutmanual_pingcallback param, This function has the proposite is pass a function as parameter, so thecallback_tsolve this pointer, it's not necessary make a pointer param to get a function... These changes also resolves the previously conflict where a little part of https was erased,Testing procedure
move to wifi-subsys/test directory and then run:
idf.py build -D "TEST_COMPONENTS=protocols" flash monitorIssues/PRs references
Fixes #195