Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated server validation use #648

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

tomasMizera
Copy link
Contributor

As a follow-up of MerginMaps/python-api-client#223. Removes outdated validation of a server URL.

Requires a new py-api release.

@tomasMizera tomasMizera added the requires dependency release Other dependencies must be released before this one label Nov 29, 2024
@jsjtadie

This comment was marked as spam.

@tomasMizera
Copy link
Contributor Author

Required dependency was merged, we can merge this one then too. Let's keep in mind that we first need to release py-client

Copy link
Contributor

@ValentinBuira ValentinBuira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! Thanks for the changes

@tomasMizera tomasMizera merged commit 2957994 into master Jan 10, 2025
7 checks passed
@tomasMizera tomasMizera deleted the remove-deprecated-validation branch January 10, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires dependency release Other dependencies must be released before this one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants