Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2320 Split geometry visual problems #3553

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

ValentinBuira
Copy link
Contributor

@ValentinBuira ValentinBuira commented Jul 31, 2024

This PR fix #2320 where the guideline from last point to cursor wasn't showing in the splitting tool

The root issue was that the GuidelineController::buildGuideline was cancelled at the beginning of the function, because of the allowed property. So I turned allowed to be always true for the splitting tool

I wanted to show clearly to the users that the actual splitting line were the one to the last point and not to the cursor.
So I updated the visual to match the way it works when adding a new line geometry
Let me know if it's working for the user experience otherwise I will revert that part

The buildGuideline method was cancelled
Copy link

github-actions bot commented Jul 31, 2024

Pull Request Test Coverage Report for Build 10215399786

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 59.991%

Files with Coverage Reduction New Missed Lines %
input/app/projectsmodel.cpp 5 69.44%
Totals Coverage Status
Change from base Build 10161670477: -0.03%
Covered Lines: 7701
Relevant Lines: 12837

💛 - Coveralls

@tomasMizera tomasMizera added the FROZEN 🥶 do not merge before upcoming release label Aug 1, 2024
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is looking good, I have just one suggestion. The first recorded point for the split line has a different color than the line. Can we unify that please?

@ValentinBuira
Copy link
Contributor Author

I changed the marker color to match the color of the line

Should be ready to merge once unfrozen

@tomasMizera tomasMizera removed the FROZEN 🥶 do not merge before upcoming release label Aug 9, 2024
@tomasMizera tomasMizera merged commit 795bf57 into master Aug 9, 2024
12 checks passed
@tomasMizera tomasMizera deleted the fix-split-geometry-visual branch August 9, 2024 07:22
@alexd0793 alexd0793 added the test-success Label to use for PR testing label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-success Label to use for PR testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split geometry visual problems
4 participants