Fix #2320 Split geometry visual problems #3553
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #2320 where the guideline from last point to cursor wasn't showing in the splitting tool
The root issue was that the
GuidelineController::buildGuideline
was cancelled at the beginning of the function, because of theallowed
property. So I turned allowed to be always true for the splitting toolI wanted to show clearly to the users that the actual splitting line were the one to the last point and not to the cursor.
So I updated the visual to match the way it works when adding a new line geometry
Let me know if it's working for the user experience otherwise I will revert that part