Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing app freeze related to MMBaseSingleLineInput #3539

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Fixing app freeze related to MMBaseSingleLineInput #3539

merged 3 commits into from
Jul 26, 2024

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented Jul 18, 2024 •
edited by tomasMizera
Loading

Small fix in MMBaseSingleLineInput.qml to prevent app freeze in the first method of reproducing issue.

Fixes (Partially) #3538

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10111955428

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 59.997%
Files with Coverage Reduction New Missed Lines %
input/app/position/providers/simulatedpositionprovider.cpp 1 90.91%
Totals Coverage Status
Change from base Build 10040562947: 0.0%
Covered Lines: 7697
Relevant Lines: 12829
💛 - Coveralls

@VitorVieiraZ VitorVieiraZ changed the title WIP - Fixing app freeze when capturing photos for a child layer Fixing app freeze when capturing photos for a child layer Jul 18, 2024
@VitorVieiraZ VitorVieiraZ requested a review from tomasMizera July 18, 2024 20:17
@VitorVieiraZ VitorVieiraZ changed the title Fixing app freeze when capturing photos for a child layer Fixing app freeze in relations editors Jul 19, 2024
@VitorVieiraZ VitorVieiraZ force-pushed the fix/appFreezeTakingPictures branch from fffad8f to 4db7c4a Compare July 19, 2024 18:46
@VitorVieiraZ VitorVieiraZ changed the title Fixing app freeze in relations editors WIP - Fixing app freeze in relations editors Jul 19, 2024
@VitorVieiraZ VitorVieiraZ force-pushed the fix/appFreezeTakingPictures branch from 4db7c4a to 5aab35d Compare July 23, 2024 01:30
@VitorVieiraZ VitorVieiraZ changed the title WIP - Fixing app freeze in relations editors Fixing app freeze related to MMBaseSingleLineInput Jul 26, 2024
@VitorVieiraZ VitorVieiraZ requested a review from tomasMizera July 26, 2024 13:21
@VitorVieiraZ VitorVieiraZ self-assigned this Jul 26, 2024
@VitorVieiraZ VitorVieiraZ added this to the 2024.3.1 milestone Jul 26, 2024
@VitorVieiraZ VitorVieiraZ added bug android 🤖 Relates to Android app version data corruption - sync failure - crash - anr The most critical classification and removed bug android 🤖 Relates to Android app version data corruption - sync failure - crash - anr The most critical classification labels Jul 26, 2024
@tomasMizera tomasMizera merged commit 87735cf into master Jul 26, 2024
12 checks passed
@tomasMizera tomasMizera deleted the fix/appFreezeTakingPictures branch July 26, 2024 13:41
@jozef-budac
Copy link

I can't simulate this om my device. Can you verify this @VitorVieiraZ ? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasMizera tomasMizera tomasMizera approved these changes

Assignees

@VitorVieiraZ VitorVieiraZ

Labels
None yet
Projects
None yet
Milestone
2024.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@VitorVieiraZ @jozef-budac @tomasMizera @inputapp-bot