Fix logic of how the "N more" is calculated in relation editor #3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea with the custom model. Certainly something to think about. Would you like to file a ticket for that? |
tomasMizera
approved these changes
Apr 12, 2024
|
Ticket created: #3310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3242
This pretty much reverts the logic to use what we had before e4b5d28. The updated logic with counting of items made invisible was more efficient in theory, but fragile in reality 🙂
The relation editor is probably quite prone to slowness if there are many related features, because Repeater may create many items even if they end up hidden and we may do many recalculations of number of hidden items. It may be a good idea to implement a custom "flow relation features" model, that would be aware of the flow parameters (number of rows, font metrics, spacing etc.) so that 1. we would only create few items even for large relations, 2. all layout logic would be in one place (and testable)