New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix freeze on start #3228

Merged

wonder-sk merged 1 commit into master from fix-freeze-on-start

Apr 3, 2024

Contributor

wonder-sk commented Apr 3, 2024

I was getting black screen upon app start on linux. It was quite horrible to debug, but in the end this is how it goes:

at some point during init, when ScaleBarKit::updateScaleBar() tries to figure out good scale bar width, the InputUtils::screenUnitsToMeters() function returns NaN because we're trying to do ellipsoid calculations with bad coordinates
NaN gets propagated and the scale bar gets width = -2147483600
ShaderEffectSource used for the blur box gets sourceRect set to -2147483600 and that gets the code stuck somewhere in Quick Scene Graph code forever

Before:

After:


          Fix freeze on start

81015ef

tomasMizera approved these changes

View reviewed changes

wonder-sk merged commit a2a31dd into master

6 of 8 checks passed

tomasMizera deleted the fix-freeze-on-start branch

April 3, 2024 15:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet