Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout of dialog drawers #3192

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Fix layout of dialog drawers #3192

merged 2 commits into from
Mar 28, 2024

Conversation

tomasMizera
Copy link
Collaborator

MMDrawerDialog now inherits MMDrawer, it is scrollable and adjusts its height based on the content height.

I replaced specialComponent done via Loader with approach that we use in other places (property alias xyz: xyzm.children), the new property is called additionalContent. This way I extracted the "boundedMessage" to a standalone component that can be used when needed.

Screenshot 2024-03-27 at 22 07 32 Screenshot 2024-03-27 at 22 07 37

With the additionalContent it can look like this:

Screenshot 2024-03-27 at 22 47 02

but you can inject any other item to it to get something custom, like:

Screenshot 2024-03-27 at 21 55 01 2

@tomasMizera tomasMizera requested a review from PeterPetrik March 27, 2024 21:49
@PeterPetrik PeterPetrik merged commit be4a9fa into master Mar 28, 2024
8 of 11 checks passed
@PeterPetrik PeterPetrik deleted the fix-dialog-drawers branch March 28, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants