Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up to date image adjustment #3189

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Up to date image adjustment #3189

merged 3 commits into from
Mar 28, 2024

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented Mar 27, 2024

Adjust: ISS-120
In main.qml, changed the icon from WaitingIcon to CheckIcon if it is already up to date.

@tomasMizera
Copy link
Collaborator

Hi Vitor! Thanks for these changes. I believe though that ISS-120 actually refers to something else - it is notification icon when the app says "Up to date" (after one clicked on the sync button). See

__notificationModel.addInfo( qsTr( "Up to date" ) )

@tomasMizera
Copy link
Collaborator

I quite liked the image that was here previously :)

Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous comments

@PeterPetrik PeterPetrik merged commit 09d55f1 into master Mar 28, 2024
9 of 11 checks passed
@PeterPetrik PeterPetrik deleted the fix-iss120 branch March 28, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants