Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMToolbar[Button] reimplementation #3166

Merged
merged 2 commits into from
Mar 21, 2024
Merged

MMToolbar[Button] reimplementation #3166

merged 2 commits into from
Mar 21, 2024

Conversation

PeterPetrik
Copy link
Contributor

  • broken MMMapController > MMMenuDrawer (@tomasMizera please replace with MMListDrawer in your PR)
  • missing "Active" green label in MMListDrawer (@tomasMizera please add to MMListDrawer in your PR)

visually it is the same, just cleared the logic and improved API

usage (detto for long buttons and selectable buttons)

  MMToolbar {
    model: ObjectModel {
      MMToolbarButton { text: "Delete"; iconSource: __style.deleteIcon; onClicked: console.log("tapped "+text) }
      MMToolbarButton { text: "Edit Geometry"; iconSource: __style.editIcon; onClicked: console.log("tapped "+text) }
      MMToolbarButton { text: "Save"; iconSource: __style.doneCircleIcon; onClicked: console.log("tapped "+text) }
    }
  }

@PeterPetrik PeterPetrik requested a review from tomasMizera March 21, 2024 15:03
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@PeterPetrik PeterPetrik merged commit 500ad10 into master Mar 21, 2024
11 checks passed
@PeterPetrik PeterPetrik deleted the toolbarv2 branch March 21, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants