Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar #3111

Merged
merged 5 commits into from
Mar 5, 2024
Merged

Toolbar #3111

merged 5 commits into from
Mar 5, 2024

Conversation

PeterPetrik
Copy link
Contributor

@PeterPetrik PeterPetrik commented Mar 5, 2024 •
edited
Loading

(demonstration of basetoolbar (green) and content (red)

Screenshot 2024-03-05 at 15 42 49

** in gallery **

Screenshot 2024-03-05 at 15 43 46
Screenshot 2024-03-05 at 15 43 54
Screenshot 2024-03-05 at 15 48 26

@PeterPetrik PeterPetrik requested a review from tomasMizera March 5, 2024 14:50
@tomasMizera
Copy link
Collaborator

😍

@tomasMizera
Copy link
Collaborator

tomasMizera commented Mar 5, 2024 •
edited
Loading

We still have a bit of work to do with the toolbar, but I am sure we can fix it in the following PRs - we need to shrink the size of the buttons
image

@PeterPetrik
Copy link
Contributor Author

made a small adjustment to reduce size of toolbar to 54 when there is safe bottom area. (normally 68).
to make bigger adjustments, we would need to adjust a lot these buttons implementations

Screenshot 2024-03-05 at 19 44 21 Screenshot 2024-03-05 at 19 44 15

@PeterPetrik PeterPetrik merged commit 868bf3a into master Mar 5, 2024
6 of 8 checks passed
@PeterPetrik PeterPetrik deleted the toolbar branch March 20, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasMizera tomasMizera tomasMizera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeterPetrik @tomasMizera