Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MMDrawer and MMPage API #3097

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Update MMDrawer and MMPage API #3097

merged 6 commits into from
Mar 4, 2024

Conversation

PeterPetrik
Copy link
Contributor

@PeterPetrik PeterPetrik commented Mar 2, 2024

  • Define bottom margin for Page and Drawer
  • Fix Android back button on Drawer

Previous description:

Questions @tomasMizera
A/ DRAWERS
1/ Shouldn't we define bottom margin? on most screen is 8 I believe (?), and then the content do not need to be offsetted from bottom in caller?
2/ I believe for drawers the top spacing is usually 20 (on pages 40, but drawers I think 20?)
3/ Shouldn't we introduce android back button for drawers too?

Screenshot 2024-03-03 at 8 22 38

Q: for Pages, don't we want bottom margin too?
Q: for drawer - the android back button should be bound to close() signal?

Copy link

github-actions bot commented Mar 2, 2024

Pull Request Test Coverage Report for Build 8141725568

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 60.089%

Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 3 72.99%
Totals Coverage Status
Change from base Build 8141182413: -0.02%
Covered Lines: 7549
Relevant Lines: 12563

💛 - Coveralls

@PeterPetrik PeterPetrik requested a review from tomasMizera March 3, 2024 07:22
@PeterPetrik PeterPetrik changed the title WIP: stakeout panel stakeout panel Mar 4, 2024
@PeterPetrik PeterPetrik changed the title stakeout panel drawer and pages exercises Mar 4, 2024
@PeterPetrik PeterPetrik changed the title drawer and pages exercises drawer tries Mar 4, 2024
@PeterPetrik PeterPetrik changed the title drawer tries drawer - stakeout Mar 4, 2024
@tomasMizera tomasMizera changed the title drawer - stakeout Update MMDrawer and MMPage API Mar 4, 2024
@tomasMizera tomasMizera self-assigned this Mar 4, 2024
@tomasMizera tomasMizera removed their request for review March 4, 2024 13:24
@PeterPetrik PeterPetrik merged commit 7eb3529 into master Mar 4, 2024
11 checks passed
@PeterPetrik PeterPetrik deleted the drawers2 branch March 4, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants