Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MMCodeScanner closeIcon and text position adjustment #3096

Merged
merged 5 commits into from
Mar 4, 2024
Merged

MMCodeScanner closeIcon and text position adjustment #3096

merged 5 commits into from
Mar 4, 2024

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented Mar 1, 2024 •
edited
Loading

  • MMHeader to MMPageHeader in MMMenuDrawer.qml
  • Code scanner closeIcon and scannerText position adjustment:

Post review:

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8140791067

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 31 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.005%) to 60.135%
Files with Coverage Reduction New Missed Lines %
input/app/position/providers/simulatedpositionprovider.cpp 1 90.91%
input/app/mmstyle.h 30 2.2%
Totals Coverage Status
Change from base Build 8109434675: -0.005%
Covered Lines: 7553
Relevant Lines: 12560
💛 - Coveralls

PeterPetrik
PeterPetrik reviewed Mar 4, 2024
View reviewed changes
app/mmstyle.h Show resolved Hide resolved
app/qml/components/MMCodeScanner.qml Outdated Show resolved Hide resolved
@VitorVieiraZ VitorVieiraZ force-pushed the CodeScanner-adjustments branch from 3d26e10 to aa167d6 Compare March 4, 2024 13:26
@PeterPetrik PeterPetrik merged commit d5cea16 into master Mar 4, 2024
6 checks passed
@PeterPetrik PeterPetrik deleted the CodeScanner-adjustments branch March 4, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterPetrik PeterPetrik PeterPetrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VitorVieiraZ @PeterPetrik