Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign of the MissingAuthDialog #3092

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Redesign of the MissingAuthDialog #3092

merged 2 commits into from
Feb 29, 2024

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented Feb 29, 2024 •
edited
Loading

  • MissingAuthDialog.qml to MMMissingAuthDialog.qml
  • Sign In image included in the gallery.

2

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 8099829700

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 30 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 60.096%
Files with Coverage Reduction New Missed Lines %
input/app/mmstyle.h 30 2.22%
Totals Coverage Status
Change from base Build 8098639056: -0.004%
Covered Lines: 7545
Relevant Lines: 12555
💛 - Coveralls

PeterPetrik
PeterPetrik reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@PeterPetrik PeterPetrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - only missing is to use it in-app somewhere?

app/qml/CMakeLists.txt
@@ -7,7 +7,7 @@ set(MM_QML
components/Symbol.qml
components/TextWithIcon.qml
dialogs/MigrateToMerginDialog.qml
dialogs/MissingAuthDialog.qml
dialogs/MMMissingAuthDialog.qml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you. need to use it in-app somewhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated MissingAuthDialog to MMMissingAuthDialog in main.qml usage

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you are right!

@PeterPetrik PeterPetrik merged commit c6bc8a7 into master Feb 29, 2024
10 of 11 checks passed
@PeterPetrik PeterPetrik deleted the missingAuthDlg-redesign branch February 29, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterPetrik PeterPetrik PeterPetrik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VitorVieiraZ @PeterPetrik