-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign of the Project Issues Panel #3065
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, keep it going 👍
app/qml/MMProjectIssuesPanel.qml
Outdated
@@ -0,0 +1,170 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to app/qml/project/MMProjectIssuesPanel.qml
app/qml/MMProjectIssuesPanel.qml
Outdated
import QtQuick.Layouts | ||
import Qt5Compat.GraphicalEffects | ||
import lc 1.0 | ||
import "." // import InputStyle singleton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove all occurrences of InputStyle
app/qml/ProjectIssuesPanel.qml
Outdated
@@ -59,7 +59,7 @@ Item { | |||
|
|||
background: Rectangle { | |||
anchors.fill: parent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this file completely
app/qml/main.qml
Outdated
//projectLoadingScreen.visible = true; | ||
projectIssuesPanel.visible = true; | ||
//failedToLoadProjectBanner.reset(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert these changes
app/qml/MMProjectIssuesPanel.qml
Outdated
visible: false | ||
property real rowHeight: InputStyle.rowHeight | ||
property var projectIssuesModel: ListModel {} | ||
property string projectLoadingLog: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this panel would be easy to add to gallery too if you want.
6823471
to
14f4edb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
In progress
ProjectIssuesPanel.qml