Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial conversion of About page, Diagnostic Log page and Changelog Page #3050

Merged
merged 6 commits into from
Feb 13, 2024

Conversation

PeterPetrik
Copy link
Contributor

  • not pixel perfect but using new components.
  • also introduced "images" so we can split images and icons
  • splitted drawers and icons pages in gallery
    Screenshot 2024-02-13 at 17 09 05
    Screenshot 2024-02-13 at 17 07 42
    Screenshot 2024-02-13 at 17 07 36

@PeterPetrik PeterPetrik requested a review from iiLubos February 13, 2024 16:13
Copy link

github-actions bot commented Feb 13, 2024

Pull Request Test Coverage Report for Build 7892274905

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 24 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 60.442%

Files with Coverage Reduction New Missed Lines %
input/app/position/providers/simulatedpositionprovider.cpp 1 90.91%
input/app/mmstyle.h 23 0.0%
Totals Coverage Status
Change from base Build 7892210617: -0.02%
Covered Lines: 7522
Relevant Lines: 12445

💛 - Coveralls

Copy link
Contributor

@iiLubos iiLubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Comment on lines +12 to +14
import QtQuick.Layouts
import QtQuick.Dialogs
import QtQuick.Window
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need all the imports

@PeterPetrik PeterPetrik merged commit 52f2a85 into master Feb 13, 2024
11 checks passed
@PeterPetrik PeterPetrik deleted the settings_pages branch February 13, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants