Send post-registration data when onboarding is completed #3049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uclaros
commented
Feb 13, 2024
| @@ -41,6 +41,7 @@ Page { | |||
| id: header | |||
|
|
|||
| title: listView.contentY > -30 * __dp ? root.headerTitle : "" | |||
| backVisible: false | |||
There was a problem hiding this comment.
Should I completely remove the root page's backClicked signal too?
Pull Request Test Coverage Report for Build 7888868480Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send post-registration data when onboarding is completed (endpoint
/v1/post-registeris not yet available in test.dev server)Success/failure is only logged and not shown to the user. He only cares that his workspace was created, so always show this.
The back button was also removed from
MMHowYouFoundUsso that users can't skip how you found us and which industry questions.