Replace login and registration panels #2966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterPetrik
force-pushed
the
onboarding_app
branch
from
715459b to
d58b20d
Compare
tomasMizera
reviewed
Dec 19, 2023
tomasMizera
reviewed
Dec 19, 2023
There was a problem hiding this comment.
@iiLubos @PeterPetrik Have you guys tested this page out on mobile devices? When user clicks on some input, the app should automatically scroll so that the input is not hidden behind the opened keyboard. This is automatically handled by Qt in case we follow their rules
There was a problem hiding this comment.
not tested on mobile so far
tomasMizera
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace login and registration panels