fix: wasm functions return undefined #11
Conversation
src/index.ts
Outdated
| @@ -33,14 +35,20 @@ export default function wasm(): Plugin { | |||
| // Make a call to Vite's internal `fileToUrl` function by calling Vite's original WASM plugin's load() | |||
| const originalLoadResult = (await originalWasmPlugin.load.call(this, id + "?init")) as string; | |||
| const url = JSON.parse(/".+"/g.exec(originalLoadResult.trim().split("\n")[1])[0]) as string; | |||
| const importUrls = await Promise.all( | |||
| imports.map(async ({ from }) => { | |||
| const importerPath = id.slice(0, id.lastIndexOf("/")) + from.slice(from.lastIndexOf("/")); | |||
There was a problem hiding this comment.
I don't really understand this path concatenation for importerPath, what would happen if the WASM file imports a JS file that are not in the same directory? e.g. when from is ../../../a/b/c/xxx.js.
There was a problem hiding this comment.
This just replace file name:
id: 'C:/t/test-wasm2/node_modules/@jsona/openapi/index_bg.wasm'
from: "./index_bg.js"
importerPath: "C:/t/test-wasm2/node_modules/@jsona/openapi/index_bg.js"
There was a problem hiding this comment.
What if
id: 'C:/t/test-wasm2/node_modules/@jsona/openapi/a/b/c/d/e/index_bg.wasm'
from: "../../f/g/index_bg.js"
There was a problem hiding this comment.
The index_bg.wasm always point to index_bg.js. in same directory.
There was a problem hiding this comment.
It only appies to wasm-bindgen, you can't assume all WASM files are generated by wasm-bindgen. I don't see in the WASM ESM spec it has any restrictions on the imported files' directory.
|
Could you add some test that fails without this PR and passes with it? I personally couldn't reproduce this issue. |
|
This happend in dev mode, I'm afraid the tests need to be refactored. Files to reproduce this issue. package.json vite.config.js import { defineConfig } from "vite";
import wasm from "vite-plugin-wasm";
import topLevelAwait from "vite-plugin-top-level-await";
export default defineConfig({
plugins: [
wasm(),
topLevelAwait(),
]
})index.html <body>
<script type="module" src="/main.js"></script>
</body>main.js import { parse } from "@jsona/openapi";
console.log(parse("{}")); |
|
I merged your code with latest main changes and added unit test. Some circular dependency happened in |
|
vitejs/vite#10141 fix version query. The easiest way to fix this problem now is to exclude wasm js module from pre-bundling (vite >= 3.1.2) In order to solve this problem perfectly, vite needs to provide api reverse lookup importer. |
This pr solve #1.
Why some wasm functions return undefined?
If you import a wasm js module:
vitewill compile this to:NOTE: vite append a version hash to module path.
vite-wasm-pluginwill resolve this to:vite-wasm-pluginimports the importer module/node_modules/@jsona/openapi/index_bg.jswithout a version hash.That's the problem. They are two different modules because their paths are different.
If you run non-local wasm js module(vite don't add version hash to non-node_module files), call a function depends on
__wbindgen*function, it will return undefined.