chore: Update SR-IOV Network Operator chart to consume new cert logic #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest-nic_operator_helm |
vasrem
changed the title
vasrem
force-pushed
the
chore/update_sriov_netop_chart
branch
3 times, most recently
from
c5db3d7 to
3d91273
Compare
vasrem
commented
Dec 27, 2023
...rator/charts/sriov-network-operator/crds/sriovnetwork.openshift.io_sriovoperatorconfigs.yaml
Outdated
Show resolved
Hide resolved
|
/retest-nic_operator_helm |
2 similar comments
|
/retest-nic_operator_helm |
|
/retest-nic_operator_helm |
vasrem
force-pushed
the
chore/update_sriov_netop_chart
branch
2 times, most recently
from
0e8b3a7 to
37fe209
Compare
|
/retest-nic_operator_helm |
Signed-off-by: Vasilis Remmas <[email protected]>
vasrem
force-pushed
the
chore/update_sriov_netop_chart
branch
from
37fe209 to
0a806f9
Compare
|
Overall LGTM, let's wait for dependent PR in SRIOV-NO |
|
/retest-nic_operator_helm |
1 similar comment
|
/retest-nic_operator_helm |
rollandf
approved these changes
Jan 3, 2024
adrianchiris
approved these changes
Jan 8, 2024
rollandf
added a commit
that referenced
this pull request
Jan 10, 2024
Requires and is based on: #709 This PR adds support for auto generated cert-manager certificates when user enables the SR-IOV Network Operator Admission Controllers via the Helm value `sriov-network-operator.operator.admissionControllers.enabled`. This PR won't work until: * a new image of SR-IOV Network Operator is published and the following value is updated https://github.com/vasrem/network-operator/blob/f125b8a67772fc31af6ced0b24c9249531e5e542/deployment/network-operator/values.yaml#L146 * a new image of SR-IOV Network Operator Webhook is published and the following value is updated https://github.com/vasrem/network-operator/blob/f125b8a67772fc31af6ced0b24c9249531e5e542/deployment/network-operator/values.yaml#L152 * This is needed to ensure smooth `helm uninstall` operation. Depends on k8snetworkplumbingwg/sriov-network-operator#566.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today it's cumbersome to enable admission controllers for SRIOV Network Operator because the user needs to create a secret manually. With this PR k8snetworkplumbingwg/sriov-network-operator#561, it's possible to generate a self signed certificate so the user doesn't need to do manual steps to enable those admission controllers.
This PR just updates the chart to the latest chart found in the
masterbranch of https://github.com/k8snetworkplumbingwg/sriov-network-operator which at the time was k8snetworkplumbingwg/sriov-network-operator@233b99a.Another PR will enable proper support for admission controllers.