Deploy default SriovNetworkNodePolicy by helm chart #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The owner of SR-IOV Device Plugin daemonset is default policy so it will be deleted both with a defaut during helm uninstall procedure. Relates-Bug: Mellanox#385 Signed-off-by: Ivan Kolodiazhny <[email protected]>
| @@ -0,0 +1,10 @@ | |||
| apiVersion: sriovnetwork.openshift.io/v1 | |||
There was a problem hiding this comment.
can you submit one for sriov-network-operator ?
There was a problem hiding this comment.
here is it: k8snetworkplumbingwg/sriov-network-operator#401
adrianchiris
approved these changes
Jan 26, 2023
almaslennikov
approved these changes
Jan 26, 2023
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The owner of SR-IOV Device Plugin daemonset is default policy so it will be deleted both with a defaut during helm uninstall procedure.
Signed-off-by: Ivan Kolodiazhnyi [email protected]