Set alpine:latest as a base image by default #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@e0ne do you understand why CI failed on this change? |
|
/retest-nic_operator |
|
@moshe010 failures aren't related to the change, need to dig deeper |
|
/retest-nic_operator_helm |
|
/retest-nic_operator_kind |
moshe010
reviewed
Jun 7, 2021
|
|
||
| ``` | ||
| docker build -t network-operator \ | ||
| --build-arg BASE_IMAGE=registry.access.redhat.com/ubi8/ubi-minimal:latest \ |
There was a problem hiding this comment.
you need to add to Travis to build both type of images (not for this release)
There was a problem hiding this comment.
We'll move it to jenkins to not hit dokerpull limit. golang image from dokcerhub is still using for base builder image
Image size changed from 346MB to 50.3MB Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
Signed-off-by: Ivan Kolodiazhny <[email protected]>
Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
|
/retest-nic_operator_helm |
1 similar comment
|
/retest-nic_operator_helm |
|
@e0ne where do you push both images to dockerhub? |
moshe010
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image size changed from 346MB to 50.3MB
Signed-off-by: Ivan Kolodiazhnyi [email protected]