Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep node features #1361

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

alekseysen
Copy link
Contributor

When uninstalling network-operator, keep labels added by node-feature-discovery.

This is done by adding cleanupLabels value to node-feature-discover chart

Note:
The name of value probably needs to be improved

When uninstalling network-operator, keep lables added by node-feature-discovery.

This is done by adding cleanupLabesl value to node-feature-discover chart
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13664888453

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 59.91%

Files with Coverage Reduction New Missed Lines %
pkg/state/state_ipoib_network.go 4 75.24%
controllers/ipoibnetwork_controller.go 7 77.38%
Totals Coverage Status
Change from base Build 13652164741: -0.2%
Covered Lines: 3340
Relevant Lines: 5575

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants