bug: fix admission_controller template while not using cert-manager #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13114796397Details
💛 - Coveralls |
almaslennikov
previously approved these changes
Feb 3, 2025
rollandf
reviewed
Feb 3, 2025
heyvister1
force-pushed
the
fix-webhook-template-cert
branch
from
c55e247 to
44a6b20
Compare
…nager usage Signed-off-by: Ido Heyvi <[email protected]>
rollandf
approved these changes
Feb 3, 2025
|
@heyvister1 Do we want this one in 25.1 branch? |
Yes. Created the following PR #1327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
ValidatingWebhookConfigurationtemplatecaBundlewas using server side tls cert instead of CA cert