fix: if chart version already exists then *won't* fail on chart-push #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caveat: If the specific error (`Chart '<chart>' already exists in the repository.`) occurs then the CI workflow (`ci.yaml`) *won't* fail. However it's important to note that the `make` command will behave normally around the failure (i.e. it will exit) - this is fine in the current configuration (Makefile & ci.yaml), however - it could cause issues in the following cases: - Expantion of the make target with additional lines (will fail and exit on the current/single line). - Addition of make goal(s) *after* the `chart-push` target (will fail and exit and not run any following targets). Signed-off-by: Michael Zeevi <[email protected]>
|
backport of #1310 |
Pull Request Test Coverage Report for Build 13110763534Details
💛 - Coveralls |
|
/retest-copy-right |
e0ne
approved these changes
Feb 3, 2025
heyvister1
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caveat:
If the specific error (
Chart '<chart>' already exists in the repository.) occurs then the CI workflow (ci.yaml) won't fail. However it's important to note that themakecommand will behave normally around the failure (i.e. it will exit) - this is fine in the current configuration (Makefile & ci.yaml), however - it could cause issues in the following cases:chart-pushtarget (will fail and exit and not run any following targets).