corrected readme #12
Merged
corrected readme #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 9, 2014 12:08
…on that got lost in the previous PR.
|
I'm sorry BTW. |
| @@ -205,6 +205,9 @@ Gives the plural of a certain word. | |||
|
|
|||
| ```kotlin | |||
| "test".pluralize() => "tests" | |||
|
|
|||
| "test".pluralize(Plurality.CouldBeEither) => "tests" | |||
There was a problem hiding this comment.
Do I really have to specify this? Is there not a notion of optional params?
Also I'm removing Plurality in Humanizer V2 and replacing it with a bool argument. More info here.
There was a problem hiding this comment.
The plurality is optional. And named.and defaults to Singular for pluralize and Plural to singularize. "test".pluralize() still exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
somehow this got missed in the previous PR because of the merge with the upstream.