Cropper: behavior on invalid Source #5916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsrki
reviewed
Dec 28, 2024
Source/Extensions/Blazorise.Cropper/wwwroot/blazorise.cropper.js
Outdated
Show resolved
Hide resolved
… (ImageLoadingFailed)
stsrki
reviewed
Dec 28, 2024
Source/Extensions/Blazorise.Cropper/wwwroot/blazorise.cropper.js
Outdated
Show resolved
Hide resolved
stsrki
approved these changes
Dec 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mentioned in #5847
This PR aims to improve the behavior on invalid
Sourcein the image cropper. The behavior mentioned in #5847 isn't actually that bad—nothing crashes, and the "transparency grid" is a good indication that something went wrong.Introduced in this PR:
Source, the cropper is disabled (and the previous state is re-enabled when theSourceis fixed).Sourcenow has theEditorRequiredattribute as it is the only way to signal to users that it's required. I don't see any reason not to use it, but I also don't see it used anywhere else. So..?ImageLoadingFailedevent was added to inform users when something goes wrong with image loading. Ensuring theSourceis correct remains the user's responsibility, but this helps handle such cases.(invalid source includes
null,""or "image/that/does/not/exist.jpg")