Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table scroll to row feature #2650

Merged
merged 5 commits into from
Jul 18, 2021
Merged

Table scroll to row feature #2650

merged 5 commits into from
Jul 18, 2021

Conversation

David-Moreira
Copy link
Contributor

Closes #2646

@David-Moreira David-Moreira requested a review from stsrki July 17, 2021 16:42
@David-Moreira David-Moreira requested a review from stsrki July 18, 2021 08:55
@stsrki
Copy link
Collaborator

stsrki commented Jul 18, 2021

Looking good now! This will come in handy :)

@stsrki stsrki merged commit 6b272bd into dev094 Jul 18, 2021
@stsrki stsrki deleted the dev094-Table-ScrollToRow branch July 18, 2021 12:00
David-Moreira
David-Moreira commented Jul 18, 2021
View reviewed changes
Copy link
Contributor Author

@David-Moreira David-Moreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this coherent with the pr you accepted from Simon removing the state machine from all async calls?
Behind the covers it should still. Allocate a Task and not a ValueTask. Same result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsrki stsrki Awaiting requested review from stsrki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@David-Moreira @stsrki