Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set selected slide on carouselSlide initialization #2572

Closed
wants to merge 20 commits into from

Conversation

codertimu
Copy link

Currently, Carousel requires the SelectedSlide to be set to function properly. Otherwise, it causes an IndexOutOfBounds exception when accessing the CarouseSlide.

Imho, this shouldn't be a requirement. SelectedSlide can be easily set with CarouselSlide initialization.

Tested and ensured it doesn't break anything.

@stsrki
Copy link
Collaborator

stsrki commented Jul 5, 2021

Thank you for the PR but since there were some issues with the merge it was quicker for me to recreate it on a separate PR. Also, I made slight optimization so that SelectedSlideChanged doesn't get called unnecessary on initialization.

In any case, I mentioned you as an original author in the release notes. Thank you!

@stsrki stsrki closed this Jul 5, 2021
@codertimu
Copy link
Author

codertimu commented Jul 5, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants