-
-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set selected slide on carouselSlide initialization #2572
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 5, 2021
Closed
Thank you for the PR but since there were some issues with the merge it was quicker for me to recreate it on a separate PR. Also, I made slight optimization so that SelectedSlideChanged doesn't get called unnecessary on initialization. In any case, I mentioned you as an original author in the release notes. Thank you! |
Not a problem at all, thank you.
On Mon 5. Jul 2021 at 16:35, Mladen Macanović ***@***.***> wrote:
Thank you for the PR but since there were some issues with the merge it
was quicker for me to recreate it on a separate PR. Also, I made slight
optimization so that SelectedSlideChanged doesn't get called unnecessary on
initialization.
In any case, I mentioned you as an original author in the release notes.
Thank you!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2572 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOH7D5AYHZY657ZQNQHKGTTWG7J5ANCNFSM47ZELPXA>
.
--
Ahmet TİMUÇİN.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Carousel requires the SelectedSlide to be set to function properly. Otherwise, it causes an IndexOutOfBounds exception when accessing the CarouseSlide.
Imho, this shouldn't be a requirement. SelectedSlide can be easily set with CarouselSlide initialization.
Tested and ensured it doesn't break anything.