Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulma GenerateAlertVariantStyles fix #2364

Merged
merged 1 commit into from
May 15, 2021
Merged

Bulma GenerateAlertVariantStyles fix #2364

merged 1 commit into from
May 15, 2021

Conversation

Jimmys20
Copy link
Contributor

@Jimmys20 Jimmys20 commented May 15, 2021

Hello, I think I found a small bug in Bulma theme generator. Bulma alerts are styled like this .notification.is-primary and not like this .notification-primary. So the styles inside ThemeAlertOptions where not applied to the Alert component. Now it works.

@stsrki
Copy link
Collaborator

stsrki commented May 15, 2021

Good catch. Looks good to me now.

Thank you!

@stsrki stsrki merged commit 43937b2 into Megabit:dev094 May 15, 2021
@stsrki stsrki mentioned this pull request May 15, 2021
@Jimmys20 Jimmys20 deleted the dev094-bulma-alert-style branch May 16, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants