-
-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table : Fixed Header Feature #2214
Table : Fixed Header Feature #2214
Conversation
Damn, it works really good in Chrome. But in Firefox it just goes beyond the table area :( I will need to investigate for some other was of doing it. |
So far I was trying a bunch of CSS only solutions but none seems to work as expected. If all fails we might go with JS route. |
Damnit... I might try a bit more. |
I'm currently doing some other PRs but I will definitely let you know if I go back to this. Also, I was looking and other frameworks and for example, MudBlazor has done it with a wrapper |
Hello, We're gonna have trouble with multiple header rows, not sure if we can avoid js on those. I have updated the branch to the current state as I don't have yet time to keep going. Just let me know if you have any ideas in the meantime. Edit: Working still just as fine on every provider. |
I tested it and it seems to work fine. Although I'm not sure if we really need to have support for multiple header rows 🤔 |
We do. We have two header rows in Datagrid, because of filter row, and we will use this feature on Virtualize. |
I'll go ahead and do the rest of the corrections when I have time if you have no objections. |
You're right. We need multiple header rows, OK, you can proceed with corrections and once you're done I can review it. Thanks! |
Hello @stsrki Seems like it "steals a pixel" both in Material and bootstrap, can you take a look see if you can easily solve it? |
For me, it seems to work on Bootstrap, although the borders look a little thick. And on Material, the borders are kinda transparent and as a result, the text from behind can be seen? Is that what you meant? If I remove the border-top it seems to work but then it breaks other stuff. I will need to play more to make it work. |
Hello,
Here's the first version of the Table Sticky Header feature we've talked about on #1977
Tested on every provider successfully.
I have used
overflow-y:overlay
to solve the problem about scrollbar taking up table width.However, I was taking a look at that css feature support. And it does not seem well supported. Specially since Firefox does not support it, and it's one of the major browsers.
@stsrki do you know an alternative css way of doing this? I was trying to avoid a js based solution.
I will also investigate more once I have more time.
https://caniuse.com/?search=CSS%20overflow%3A%20overlay