Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start day of week option #2007

Conversation

danypellerin
Copy link

Was tested manually but I had issues with running E2E tests with Selenium,

- only for Blazorise material
@stsrki
Copy link
Collaborator

stsrki commented Mar 10, 2021

I'm not sure what to do with the feature to tell you the truth 😅

For the last couple of hours, I was refactoring DateEdit and TimeEdit to work with flatpickr. And DateEdit will have this feature also.

I really appreciate the effort and I would gladly accept, as it looks really good, but considering it will be overwritten I will need to close this PR. I hope that is OK? Sorry 😥

@danypellerin
Copy link
Author

I don't see it as a problem at all. If it has this feature then it's all good for me. 👍

It introduced me to the code and the repo and as we are planning on using this for some of our projects, I may contribute on some other things. I might request a bit of help in the Slack since I wasn't able to make Selenium run properly and I'd very much like to be able to do that next time.

@stsrki
Copy link
Collaborator

stsrki commented Mar 11, 2021

Thanks. When I finish the new PR can I ask you for a review? The more people test the better :)

@stsrki stsrki closed this Mar 11, 2021
@danypellerin
Copy link
Author

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants